Page 1 of 1

Stacking: when is a tactic not a tactic?

Posted: Mon Dec 28, 2015 5:34 pm
by Omegus
As per Azareal's post (http://www.returnofreckoning.com/forum/ ... ing#p60141) tactics have their own stacking group. However, does/should this still apply for tactics that proc effects?

Here's an example currently in the game: the Zealot has a tactic named "Warping the Spirit" which has a type of "Healing". This tactic can proc an armour bonus if certain conditions are met. The armour bonus proc effect has the tactic icon, is also named "Warping the Spirit" but has a type of "Buff" rather than matching the "Healing" type that was on the tactic.

Currently when this tactic procs on a player who is under the effect of an armour potion (potion effect is listed as "Buff"), the two armour bonuses are not added together even though one is from a potion and one is from a tactic.

Is this the correct behaviour? If so, is it possible to get a breakdown of exactly how the game treats tactic procs compared to tactic passives? What about non-proccing tactics that are listed as being "Buffs" in the tactics window?

Sorry for the awkward questions :)

Re: Stacking: when is a tactic not a tactic?

Posted: Mon Dec 28, 2015 5:38 pm
by bloodi
Omegus wrote:Is this the correct behaviour? If so, is it possible to get a breakdown of exactly how the game treats tactic procs compared to tactic passives? What about non-proccing tactics that are listed as being "Buffs" in the tactics window?
It doesnt matter if it comes from a tactic, ability, potion or Sigmarjesus himself, it gives an armor buff and buffs of the same type dont stack between themselves.

I dont see the confusion here, thats all there is to it. To clarify a tactic that gives +x stat is not giving a buff, however if the tactic procs a buff on you, that buff has all stacking rules of buffs applied to it.

Re: Stacking: when is a tactic not a tactic?

Posted: Mon Dec 28, 2015 6:12 pm
by Azarael
This looks like a bug. The way I've implemented tactics generally in RoR is that they all stack with each other in the Tactics stacking group, regardless of whether the effect is applied directly via the base tactic buff or indirectly via a procced buff. Warping the Spirit and Regenerative Shielding had their base tactic marked correctly but not the buff they create.

For base stat bonuses, this behaviour can be verified by looking at the paperdoll. If it matches the output of .getstats, my handling is correct. The reason this doesn't work for armor is because the server is, for some reason, authoritative over the armor stat.

Re: Stacking: when is a tactic not a tactic?

Posted: Mon Dec 28, 2015 7:33 pm
by Omegus
bloodi wrote:buffs of the same type dont stack between themselves.
lol no
Azarael wrote:This looks like a bug. The way I've implemented tactics generally in RoR is that they all stack with each other in the Tactics stacking group, regardless of whether the effect is applied directly via the base tactic buff or indirectly via a procced buff. Warping the Spirit and Regenerative Shielding had their base tactic marked correctly but not the buff they create.

For base stat bonuses, this behaviour can be verified by looking at the paperdoll. If it matches the output of .getstats, my handling is correct. The reason this doesn't work for armor is because the server is, for some reason, authoritative over the armor stat.
Thanks for the reply :).

.getstats matches the paperdoll on this one which is why I was confused about how tactic proc buffs were handled in general. I'll put it on the bug tracker.

Re: Stacking: when is a tactic not a tactic?

Posted: Mon Dec 28, 2015 8:42 pm
by Vigfuss
Is that how it worked on Live? I don't remember.

Re: Stacking: when is a tactic not a tactic?

Posted: Mon Dec 28, 2015 9:10 pm
by Luth
Tactic buff + ability buff = stacking, ability buff + ability buff = no stacking (only the strongest is counted).